TIND ILS: Add 269, 720 fields #3413
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#3409 is merged, so go ahead and rebase! |
|
Will do, out sick for the moment so it might be a bit 😄 |
- 720 fields are sometimes used e.g. in datasets to describe additional contributors. - Use 720 field as a contributor. - Note that tests will fail until zotero#3409 is merged. This is because the MARC code assumes that all books with no authors that have contributors are actually meant to be editors, which is invalid. However, we have no way of setting items to be not Book without zotero#3409.
- Refactor MARCXML importer to expose a utility function, similar to the MARC importer. This will allow consumers of the MARCXML translator to instead decide to manually drive the process.
- Convert to using the MARCXML utility function directly - Use the MARCXML utility to read date from the 269 field, which is a non-standard MARC field.
skairunner
force-pushed
the
contributors
branch
from
5a4a049 to
257dfde
Compare
|
I have updated the branch. It seems CI fails because I modified MARC.js and MARCXML.js which are used by over 10 translators. |
AbeJellinek
requested changes
Feb 3, 2025
MARC.js
Outdated
| "creators": [ | ||
| { | ||
| "lastName": "Meta Platforms, Inc", | ||
| "creatorType": "contributor", |
There was a problem hiding this comment.
This test is failing because the translator returns editor, not contributor. I think editor is more correct, but the test needs to be updated.
There was a problem hiding this comment.
Right, editor is what would be expected:
- since the example MARC doesn't have a leader, it defaults to book
- The MARC doesn't have any authors
- There's some code in MARC.js that sets all creators to editor if a book has no authors
I don't know if more correct is what I'd say in terms of how MARC should behave, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will remain a draft until #3409 is merged for two reasons: